MCP/mcesptool
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix esptool skip condition to use shutil.which

Browse Source 
The test was hardcoded to check /usr/bin/esptool, but esptool lives
in ~/.local/bin/ on this system. Use shutil.which() to properly
search PATH.
This commit is contained in:
Ryan Malloy 2026-01-28 15:46:55 -07:00
parent 64c1505a00
commit 0d684088a4
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/test_config.py
View File

@ -3,6 +3,7 @@ Test configuration management
""" """
import os import os
import shutil
from pathlib import Path from pathlib import Path
import pytest import pytest
@ -74,11 +75,10 @@ def test_common_ports():
assert len(ports) > 0 # Should return some ports for any platform assert len(ports) > 0 # Should return some ports for any platform
@pytest.mark.skipif(not Path("/usr/bin/esptool").exists(), reason="esptool not found") @pytest.mark.skipif(not shutil.which("esptool"), reason="esptool not found in PATH")
def test_tool_availability(): def test_tool_availability():
"""Test tool availability check""" """Test tool availability check"""
config = ESPToolServerConfig() config = ESPToolServerConfig()
# This should work if esptool is in PATH
available = config._check_tool_availability("esptool") available = config._check_tool_availability("esptool")
assert isinstance(available, bool) assert available is True