a5c600b07f
Standardizes communication between the Python bridge and Java plugin, resolves test logic errors, and improves error handling to ensure MCP bridge tests pass reliably. Key changes: - Standardized HTTP methods: Use GET for read operations and POST for all modification operations across the bridge and plugin. - Fixed JSON parsing in Java plugin using Gson and added missing imports. - Corrected error handling in Java plugin's `get_function` to return `success: false` when a function is not found. - Updated Python bridge's `safe_get` to correctly propagate nested failure responses from the plugin. - Fixed test client logic (`test_mcp_client.py`) to correctly extract function name/address from `list_functions` results. - Added logging to `test_mcp_client.py` for easier debugging of mutating operations.
195 lines
9.6 KiB
Python
195 lines
9.6 KiB
Python
#!/usr/bin/env python3
|
|
"""
|
|
Test script for the GhydraMCP bridge using the MCP client.
|
|
This script tests the bridge by sending MCP requests and handling responses.
|
|
"""
|
|
import json
|
|
import logging
|
|
import sys
|
|
from typing import Any
|
|
|
|
import anyio
|
|
from mcp.client.session import ClientSession
|
|
from mcp.client.stdio import StdioServerParameters, stdio_client
|
|
|
|
# Set up logging
|
|
logging.basicConfig(level=logging.INFO)
|
|
logger = logging.getLogger("mcp_client_test")
|
|
|
|
async def test_bridge():
|
|
"""Test the bridge using the MCP client"""
|
|
# Configure the server parameters
|
|
server_parameters = StdioServerParameters(
|
|
command=sys.executable,
|
|
args=["bridge_mcp_hydra.py"],
|
|
)
|
|
|
|
# Connect to the bridge
|
|
logger.info("Connecting to bridge...")
|
|
async with stdio_client(server_parameters) as (read_stream, write_stream):
|
|
# Create a session
|
|
logger.info("Creating session...")
|
|
async with ClientSession(read_stream, write_stream) as session:
|
|
# Initialize the session
|
|
logger.info("Initializing session...")
|
|
init_result = await session.initialize()
|
|
logger.info(f"Initialization result: {init_result}")
|
|
|
|
# List tools
|
|
logger.info("Listing tools...")
|
|
tools_result = await session.list_tools()
|
|
logger.info(f"Tools result: {tools_result}")
|
|
|
|
# Call the list_instances tool
|
|
logger.info("Calling list_instances tool...")
|
|
list_instances_result = await session.call_tool("list_instances")
|
|
logger.info(f"List instances result: {list_instances_result}")
|
|
|
|
# Call the discover_instances tool
|
|
logger.info("Calling discover_instances tool...")
|
|
discover_instances_result = await session.call_tool("discover_instances")
|
|
logger.info(f"Discover instances result: {discover_instances_result}")
|
|
|
|
# Call the list_functions tool
|
|
logger.info("Calling list_functions tool...")
|
|
list_functions_result = await session.call_tool(
|
|
"list_functions",
|
|
arguments={"port": 8192, "offset": 0, "limit": 5}
|
|
)
|
|
logger.info(f"List functions result: {list_functions_result}")
|
|
|
|
# Test mutating operations by changing and reverting
|
|
logger.info("Testing mutating operations...")
|
|
|
|
try:
|
|
# Get a known function to test with from list_functions result
|
|
list_funcs = await session.call_tool(
|
|
"list_functions",
|
|
arguments={"port": 8192, "offset": 0, "limit": 5}
|
|
)
|
|
|
|
if not list_funcs or not list_funcs.content:
|
|
logger.warning("No functions found - skipping mutating tests")
|
|
return
|
|
|
|
# The list_functions result contains the function data directly
|
|
if not list_funcs.content:
|
|
logger.warning("No function data found - skipping mutating tests")
|
|
return
|
|
|
|
# Parse the JSON response
|
|
try:
|
|
func_data = json.loads(list_funcs.content[0].text)
|
|
func_list = func_data.get("result", [])
|
|
if not func_list:
|
|
logger.warning("No functions in result - skipping mutating tests")
|
|
return
|
|
|
|
# Get first function's name and address directly from list_functions result
|
|
first_func = func_list[0]
|
|
func_name = first_func.get("name", "")
|
|
func_address = first_func.get("address", "") # Get address directly
|
|
|
|
if not func_name or not func_address:
|
|
logger.warning("No function name/address found in list_functions result - skipping mutating tests")
|
|
return
|
|
|
|
except json.JSONDecodeError as e:
|
|
logger.warning(f"Error parsing list_functions data: {e} - skipping mutating tests")
|
|
return
|
|
|
|
# Test function renaming
|
|
original_name = func_name
|
|
test_name = f"{func_name}_test"
|
|
|
|
# Test successful rename operations
|
|
rename_args = {"port": 8192, "name": original_name, "new_name": test_name}
|
|
logger.info(f"Calling update_function with args: {rename_args}")
|
|
rename_result = await session.call_tool("update_function", arguments=rename_args)
|
|
rename_data = json.loads(rename_result.content[0].text)
|
|
assert rename_data.get("success") is True, f"Rename failed: {rename_data}"
|
|
logger.info(f"Rename result: {rename_result}")
|
|
|
|
# Verify rename
|
|
renamed_func = await session.call_tool(
|
|
"get_function",
|
|
arguments={"port": 8192, "name": test_name}
|
|
)
|
|
renamed_data = json.loads(renamed_func.content[0].text)
|
|
assert renamed_data.get("success") is True, f"Get renamed function failed: {renamed_data}"
|
|
logger.info(f"Renamed function result: {renamed_func}")
|
|
|
|
# Rename back to original
|
|
revert_args = {"port": 8192, "name": test_name, "new_name": original_name}
|
|
logger.info(f"Calling update_function with args: {revert_args}")
|
|
revert_result = await session.call_tool("update_function", arguments=revert_args)
|
|
revert_data = json.loads(revert_result.content[0].text)
|
|
assert revert_data.get("success") is True, f"Revert rename failed: {revert_data}"
|
|
logger.info(f"Revert rename result: {revert_result}")
|
|
|
|
# Verify revert
|
|
original_func = await session.call_tool(
|
|
"get_function",
|
|
arguments={"port": 8192, "name": original_name}
|
|
)
|
|
original_data = json.loads(original_func.content[0].text)
|
|
assert original_data.get("success") is True, f"Get original function failed: {original_data}"
|
|
logger.info(f"Original function result: {original_func}")
|
|
|
|
# Test successful comment operations
|
|
test_comment = "Test comment from MCP client"
|
|
comment_args = {"port": 8192, "address": func_address, "comment": test_comment}
|
|
logger.info(f"Calling set_decompiler_comment with args: {comment_args}")
|
|
comment_result = await session.call_tool("set_decompiler_comment", arguments=comment_args)
|
|
comment_data = json.loads(comment_result.content[0].text)
|
|
assert comment_data.get("success") is True, f"Add comment failed: {comment_data}"
|
|
logger.info(f"Add comment result: {comment_result}")
|
|
|
|
# Remove comment
|
|
remove_comment_args = {"port": 8192, "address": func_address, "comment": ""}
|
|
logger.info(f"Calling set_decompiler_comment with args: {remove_comment_args}")
|
|
remove_comment_result = await session.call_tool("set_decompiler_comment", arguments=remove_comment_args)
|
|
remove_data = json.loads(remove_comment_result.content[0].text)
|
|
assert remove_data.get("success") is True, f"Remove comment failed: {remove_data}"
|
|
logger.info(f"Remove comment result: {remove_comment_result}")
|
|
|
|
# Test expected failure cases
|
|
# Try to rename non-existent function
|
|
bad_rename_args = {"port": 8192, "name": "nonexistent_function", "new_name": "should_fail"}
|
|
logger.info(f"Calling update_function with args: {bad_rename_args}")
|
|
bad_rename_result = await session.call_tool("update_function", arguments=bad_rename_args)
|
|
logger.info(f"Bad rename result: {bad_rename_result}") # Log the response
|
|
bad_rename_data = json.loads(bad_rename_result.content[0].text)
|
|
assert bad_rename_data.get("success") is False, f"Renaming non-existent function should fail, but got: {bad_rename_data}"
|
|
|
|
# Try to get non-existent function
|
|
bad_get_result = await session.call_tool(
|
|
"get_function",
|
|
arguments={"port": 8192, "name": "nonexistent_function"}
|
|
)
|
|
logger.info(f"Bad get result: {bad_get_result}") # Log the response
|
|
bad_get_data = json.loads(bad_get_result.content[0].text)
|
|
assert bad_get_data.get("success") is False, f"Getting non-existent function should fail, but got: {bad_get_data}"
|
|
|
|
# Try to comment on invalid address
|
|
bad_comment_args = {"port": 8192, "address": "0xinvalid", "comment": "should fail"}
|
|
logger.info(f"Calling set_decompiler_comment with args: {bad_comment_args}")
|
|
bad_comment_result = await session.call_tool("set_decompiler_comment", arguments=bad_comment_args)
|
|
bad_comment_data = json.loads(bad_comment_result.content[0].text)
|
|
assert bad_comment_data.get("success") is False, "Commenting on invalid address should fail"
|
|
|
|
except Exception as e:
|
|
logger.error(f"Error testing mutating operations: {e}")
|
|
raise
|
|
|
|
def main():
|
|
"""Main entry point"""
|
|
try:
|
|
anyio.run(test_bridge)
|
|
except Exception as e:
|
|
logger.error(f"Error: {e}")
|
|
sys.exit(1)
|
|
|
|
if __name__ == "__main__":
|
|
main()
|