MCP/playwright-mcp
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: prevent large screenshots from being sent to API while preserving file save

Browse Source 
- Block images exceeding 8000px from being included in MCP responses
- Add clear warning messages when images are too large for API
- Always save screenshots to file regardless of size
- Prevents conversation history issues with oversized fullPage screenshots
- Add test script for verifying large image protection

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Ryan Malloy 2025-09-04 14:46:35 -06:00
parent f31b9778c9
commit c9c82470e8
2 changed files with 88 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/tools/screenshot.ts
View File

@ -62,7 +62,7 @@ const screenshotSchema = z.object({
filename: z.string().optional().describe('File name to save the screenshot to. Defaults to `page-{timestamp}.{png|jpeg}` if not specified.'), filename: z.string().optional().describe('File name to save the screenshot to. Defaults to `page-{timestamp}.{png|jpeg}` if not specified.'),
element: z.string().optional().describe('Human-readable element description used to obtain permission to screenshot the element. If not provided, the screenshot will be taken of viewport. If element is provided, ref must be provided too.'), element: z.string().optional().describe('Human-readable element description used to obtain permission to screenshot the element. If not provided, the screenshot will be taken of viewport. If element is provided, ref must be provided too.'),
ref: z.string().optional().describe('Exact target element reference from the page snapshot. If not provided, the screenshot will be taken of viewport. If ref is provided, element must be provided too.'), ref: z.string().optional().describe('Exact target element reference from the page snapshot. If not provided, the screenshot will be taken of viewport. If ref is provided, element must be provided too.'),
fullPage: z.boolean().optional().describe('When true, takes a screenshot of the full scrollable page, instead of the currently visible viewport. Cannot be used with element screenshots.'), fullPage: z.boolean().optional().describe('When true, takes a screenshot of the full scrollable page, instead of the currently visible viewport. Cannot be used with element screenshots. WARNING: Full page screenshots may exceed API size limits on long pages.'),
allowLargeImages: z.boolean().optional().describe('Allow images with dimensions exceeding 8000 pixels (API limit). Default false - will error if image is too large to prevent API failures.'), allowLargeImages: z.boolean().optional().describe('Allow images with dimensions exceeding 8000 pixels (API limit). Default false - will error if image is too large to prevent API failures.'),
}).refine(data => { }).refine(data => {
return !!data.element === !!data.ref; return !!data.element === !!data.ref;
@ -160,10 +160,29 @@ const screenshot = defineTabTool({
} }
response.addResult(resultMessage); response.addResult(resultMessage);
// Only add image to response if dimensions are safe or explicitly allowed
let addImageToResponse = true;
if (!params.allowLargeImages) {
try {
const { width, height } = getImageDimensions(buffer);
const maxDimension = 8000;
if (width > maxDimension || height > maxDimension) {
addImageToResponse = false;
}
} catch (dimensionError) {
// If we can't parse dimensions, continue and add the image
}
}
if (addImageToResponse) {
response.addImage({ response.addImage({
contentType: fileType === 'png' ? 'image/png' : 'image/jpeg', contentType: fileType === 'png' ? 'image/png' : 'image/jpeg',
data: buffer data: buffer
}); });
} else {
response.addResult(`\n\n🚫 **Image not included in response**: Screenshot exceeds API size limits (8000px). Image saved to file only.`);
}
} }
}); });

64
test-large-screenshot.js Executable file
View File

@ -0,0 +1,64 @@
#!/usr/bin/env node
/**
* Test script to verify large screenshot handling
* Creates a very tall page and tests fullPage screenshot protection
*/
const { execSync } = require('child_process');
const fs = require('fs');
const path = require('path');
async function testLargeScreenshot() {
console.log('🧪 Testing large screenshot protection...');
// Create a simple HTML page that will be very tall
const testHtml = `
<!DOCTYPE html>
<html>
<head>
<title>Large Page Test</title>
<style>
.tall-content {
height: 10000px;
background: linear-gradient(to bottom, #ff0000, #00ff00, #0000ff);
display: flex;
align-items: center;
justify-content: center;
font-size: 48px;
color: white;
text-shadow: 2px 2px 4px rgba(0,0,0,0.5);
}
</style>
</head>
<body>
<div class="tall-content">
This is a very tall page (10000px height)<br>
Should trigger large image protection
</div>
</body>
</html>
`;
const testFile = path.join(__dirname, 'test-large-page.html');
fs.writeFileSync(testFile, testHtml);
console.log(`📄 Created test file: ${testFile}`);
console.log('🔧 This test requires manual verification with an MCP client');
console.log('');
console.log('To test:');
console.log('1. Start MCP server: npm run build && node lib/index.js');
console.log(`2. Navigate to: file://${testFile}`);
console.log('3. Try: browser_take_screenshot {"fullPage": true}');
console.log('4. Verify: Image saved to file but NOT included in response');
console.log('5. Should see: "🚫 **Image not included in response**" message');
console.log('');
console.log('Expected behavior:');
console.log('- Screenshot file should be created');
console.log('- No large image sent to API (prevents conversation issues)');
console.log('- Clear warning message displayed');
return testFile;
}
testLargeScreenshot().catch(console.error);