From 09dbcfe51264e24a7cb558a3504753c3a2e2c285 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sybren=20A=2E=20St=C3=BCvel?= Date: Fri, 27 May 2022 16:44:51 +0200 Subject: [PATCH] Remove the need to get elements by their ID Referencing elements outside the current component by ID is not a good approach; using `this.$el.parentElement` is a bit cleaner. --- web/app/src/components/TasksTable.vue | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/web/app/src/components/TasksTable.vue b/web/app/src/components/TasksTable.vue index 25b09e3e..f35ca920 100644 --- a/web/app/src/components/TasksTable.vue +++ b/web/app/src/components/TasksTable.vue @@ -5,7 +5,7 @@ :activeStatuses="shownStatuses" @click="toggleStatusFilter" /> -
+
@@ -181,8 +181,8 @@ export default { else if (row.reinitialize) row.reinitialize(true); }, _setTableHeight() { - let jobDetailsColumn = document.getElementById('col-job-details'); - let taskListTable = document.getElementById('task-list-container'); + const jobDetailsColumn = this.$el.parentElement; + const tableContainer = this.tabulator.element.parentElement; if (!jobDetailsColumn || !taskListTable) { return;