From 0fb252083b16ef61dc7e68a67ad455eba72a3c19 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sybren=20A=2E=20St=C3=BCvel?= Date: Tue, 21 Mar 2023 10:45:34 +0100 Subject: [PATCH] Job deletion: when stopping to queue up more deletions, log how many remain When queueing up jobs to be deleted, log how many deletions remain to be picked up later. Once a minute the database is checked for such deletion requests, so the next batch will be scheduled in a minute. --- internal/manager/job_deleter/job_deleter.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/internal/manager/job_deleter/job_deleter.go b/internal/manager/job_deleter/job_deleter.go index 5f45447f..da3dfa1f 100644 --- a/internal/manager/job_deleter/job_deleter.go +++ b/internal/manager/job_deleter/job_deleter.go @@ -126,13 +126,17 @@ func (s *Service) queuePendingDeletions(ctx context.Context) { return } + numDeletionsQueued := len(jobUUIDs) queueLoop: - for _, jobUUID := range jobUUIDs { + for index, jobUUID := range jobUUIDs { select { case s.queue <- jobUUID: log.Debug().Str("job", jobUUID).Msg("job deleter: job queued for deletion") case <-time.After(100 * time.Millisecond): - log.Info().Msg("job deleter: job deletion queue is full") + numRemaining := numDeletionsQueued - index + log.Info(). + Int("deletionsRemaining", numRemaining). + Msg("job deleter: job deletion queue is full, remaining deletions will be picked up later") break queueLoop } }