From 1055aabee2d9e41c63cf286c16a36d99a1ad8272 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sybren=20A=2E=20St=C3=BCvel?= Date: Fri, 15 Jul 2022 14:07:07 +0200 Subject: [PATCH] Manager: optimise db.SaveActivity() query Use an explicit `Select()` GORM call to avoid saving related objects. --- internal/manager/persistence/jobs.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/internal/manager/persistence/jobs.go b/internal/manager/persistence/jobs.go index 1fcc5ec7..504ee300 100644 --- a/internal/manager/persistence/jobs.go +++ b/internal/manager/persistence/jobs.go @@ -254,7 +254,10 @@ func (db *DB) SaveTask(ctx context.Context, t *Task) error { } func (db *DB) SaveTaskActivity(ctx context.Context, t *Task) error { - if err := db.gormDB.Model(t).Updates(Task{Activity: t.Activity}).Error; err != nil { + if err := db.gormDB.WithContext(ctx). + Model(t). + Select("Activity"). + Updates(Task{Activity: t.Activity}).Error; err != nil { return taskError(err, "saving task activity") } return nil