From 11e5363d24e0744546d7643aec9df96837bb9962 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sybren=20A=2E=20St=C3=BCvel?= Date: Mon, 1 Aug 2022 18:55:33 +0200 Subject: [PATCH] Manager: reject removal of empty list of blocklist entries A request to remove an empty list of blocklist entries now results in a 400 Bad Request. --- internal/manager/api_impl/jobs.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/internal/manager/api_impl/jobs.go b/internal/manager/api_impl/jobs.go index af1ab0a0..eb5718ed 100644 --- a/internal/manager/api_impl/jobs.go +++ b/internal/manager/api_impl/jobs.go @@ -376,6 +376,9 @@ func (f *Flamenco) RemoveJobBlocklist(e echo.Context, jobID string) error { logger.Warn().Err(err).Msg("bad request received") return sendAPIError(e, http.StatusBadRequest, "invalid format") } + if len(entriesToRemove) == 0 { + return sendAPIError(e, http.StatusBadRequest, "empty list of blocklist entries given") + } var lastErr error for _, entry := range entriesToRemove {