From 1ac72bd3fc489eb083ab74c1129fc4d92446a6c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sybren=20A=2E=20St=C3=BCvel?= Date: Fri, 20 May 2022 16:54:30 +0200 Subject: [PATCH] Web: no longer do filtering when clicking on the 'status' table cell Clicking on a job/task in their respective lists will now always activate it, regardless of where on the row was clicked. Managing the filters by clicking on the status was a nice idea, but was confusing in practice. --- web/app/src/components/JobsTable.vue | 7 ------- web/app/src/components/TasksTable.vue | 7 ------- 2 files changed, 14 deletions(-) diff --git a/web/app/src/components/JobsTable.vue b/web/app/src/components/JobsTable.vue index ae1a6cd6..23343d01 100644 --- a/web/app/src/components/JobsTable.vue +++ b/web/app/src/components/JobsTable.vue @@ -144,13 +144,6 @@ export default { // store. There were some issues where navigating to another job would // overwrite the old job's ID, and this prevents that. const rowData = plain(row.getData()); - - // Depending on which cell was clicked, take a different action. - const columnName = event.target.getAttribute("tabulator-field"); - if (columnName == "status") { - this.toggleStatusFilter(rowData.status); - return; - } this.$emit("tableRowClicked", rowData); }, toggleStatusFilter(status) { diff --git a/web/app/src/components/TasksTable.vue b/web/app/src/components/TasksTable.vue index b629dc03..334cc784 100644 --- a/web/app/src/components/TasksTable.vue +++ b/web/app/src/components/TasksTable.vue @@ -140,13 +140,6 @@ export default { // store. There were some issues where navigating to another job would // overwrite the old job's ID, and this prevents that. const rowData = plain(row.getData()); - - // Depending on which cell was clicked, take a different action. - const columnName = event.target.getAttribute("tabulator-field"); - if (columnName == "status") { - this.toggleStatusFilter(rowData.status); - return; - } this.$emit("tableRowClicked", rowData); }, toggleStatusFilter(status) {