blender/flamenco
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cleanup: test errors with assert.NoError() instead of assert.Nil()

Browse Source 
No functional changes, just nicer way to test.
This commit is contained in:
Sybren A. Stüvel 2022-06-13 15:28:53 +02:00
parent 6fc936d0a6
commit 25d5b01b3c
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
internal/manager/job_compilers/js_globals_test.go
View File

@ -10,7 +10,7 @@ import (
func TestFrameChunkerHappyBlenderStyle(t *testing.T) { func TestFrameChunkerHappyBlenderStyle(t *testing.T) {
chunks, err := jsFrameChunker("1..10,20..25,40,3..8", 4) chunks, err := jsFrameChunker("1..10,20..25,40,3..8", 4)
assert.Nil(t, err) assert.NoError(t, err)
assert.Equal(t, []string{"1-4", "5-8", "9,10,20,21", "22-25", "40"}, chunks) assert.Equal(t, []string{"1-4", "5-8", "9,10,20,21", "22-25", "40"}, chunks)
} }
@ -21,30 +21,30 @@ func TestFrameChunkerHappySmallInput(t *testing.T) {
// Just one frame. // Just one frame.
chunks, err := jsFrameChunker("47", 4) chunks, err := jsFrameChunker("47", 4)
assert.Nil(t, err) assert.NoError(t, err)
assert.Equal(t, []string{"47"}, chunks) assert.Equal(t, []string{"47"}, chunks)
// Just one range of exactly one chunk. // Just one range of exactly one chunk.
chunks, err = jsFrameChunker("1-3", 3) chunks, err = jsFrameChunker("1-3", 3)
assert.Nil(t, err) assert.NoError(t, err)
assert.Equal(t, []string{"1-3"}, chunks) assert.Equal(t, []string{"1-3"}, chunks)
} }
func TestFrameChunkerHappyRegularStyle(t *testing.T) { func TestFrameChunkerHappyRegularStyle(t *testing.T) {
chunks, err := jsFrameChunker("1-10,20-25,40", 4) chunks, err := jsFrameChunker("1-10,20-25,40", 4)
assert.Nil(t, err) assert.NoError(t, err)
assert.Equal(t, []string{"1-4", "5-8", "9,10,20,21", "22-25", "40"}, chunks) assert.Equal(t, []string{"1-4", "5-8", "9,10,20,21", "22-25", "40"}, chunks)
} }
func TestFrameChunkerHappyExtraWhitespace(t *testing.T) { func TestFrameChunkerHappyExtraWhitespace(t *testing.T) {
chunks, err := jsFrameChunker(" 1 .. 10,\t20..25\n,40 ", 4) chunks, err := jsFrameChunker(" 1 .. 10,\t20..25\n,40 ", 4)
assert.Nil(t, err) assert.NoError(t, err)
assert.Equal(t, []string{"1-4", "5-8", "9,10,20,21", "22-25", "40"}, chunks) assert.Equal(t, []string{"1-4", "5-8", "9,10,20,21", "22-25", "40"}, chunks)
} }
func TestFrameRangeExplode(t *testing.T) { func TestFrameRangeExplode(t *testing.T) {
frames, err := frameRangeExplode("1..10,20..25,40") frames, err := frameRangeExplode("1..10,20..25,40")
assert.Nil(t, err) assert.NoError(t, err)
assert.Equal(t, []int{ assert.Equal(t, []int{
1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10,
20, 21, 22, 23, 24, 25, 40, 20, 21, 22, 23, 24, 25, 40,

2
internal/worker/config_test.go
View File

@ -11,7 +11,7 @@ import (
func TestParseURL(t *testing.T) { func TestParseURL(t *testing.T) {
test := func(expected, input string) { test := func(expected, input string) {
actualURL, err := ParseURL(input) actualURL, err := ParseURL(input)
assert.Nil(t, err) assert.NoError(t, err)
assert.Equal(t, expected, actualURL.String()) assert.Equal(t, expected, actualURL.String())
} }