Cleanup: test errors with assert.NoError() instead of assert.Nil()

No functional changes, just nicer way to test.

internal/manager/job_compilers/js_globals_test.go

@@ -10,7 +10,7 @@ import (
 
 func TestFrameChunkerHappyBlenderStyle(t *testing.T) {
 	chunks, err := jsFrameChunker("1..10,20..25,40,3..8", 4)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	assert.Equal(t, []string{"1-4", "5-8", "9,10,20,21", "22-25", "40"}, chunks)
 }
 
@@ -21,30 +21,30 @@ func TestFrameChunkerHappySmallInput(t *testing.T) {
 
 	// Just one frame.
 	chunks, err := jsFrameChunker("47", 4)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	assert.Equal(t, []string{"47"}, chunks)
 
 	// Just one range of exactly one chunk.
 	chunks, err = jsFrameChunker("1-3", 3)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	assert.Equal(t, []string{"1-3"}, chunks)
 }
 
 func TestFrameChunkerHappyRegularStyle(t *testing.T) {
 	chunks, err := jsFrameChunker("1-10,20-25,40", 4)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	assert.Equal(t, []string{"1-4", "5-8", "9,10,20,21", "22-25", "40"}, chunks)
 }
 
 func TestFrameChunkerHappyExtraWhitespace(t *testing.T) {
 	chunks, err := jsFrameChunker(" 1  .. 10,\t20..25\n,40   ", 4)
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	assert.Equal(t, []string{"1-4", "5-8", "9,10,20,21", "22-25", "40"}, chunks)
 }
 
 func TestFrameRangeExplode(t *testing.T) {
 	frames, err := frameRangeExplode("1..10,20..25,40")
-	assert.Nil(t, err)
+	assert.NoError(t, err)
 	assert.Equal(t, []int{
 		1, 2, 3, 4, 5, 6, 7, 8, 9, 10,
 		20, 21, 22, 23, 24, 25, 40,

internal/worker/config_test.go

@@ -11,7 +11,7 @@ import (
 func TestParseURL(t *testing.T) {
 	test := func(expected, input string) {
 		actualURL, err := ParseURL(input)
-		assert.Nil(t, err)
+		assert.NoError(t, err)
 		assert.Equal(t, expected, actualURL.String())
 	}