From 28cc7b7a3f2df0b28f84bcf66571a5234d2c91c6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sybren=20A=2E=20St=C3=BCvel?= Date: Mon, 3 Apr 2023 18:07:47 +0200 Subject: [PATCH] Manager: improve logging when workers register The info message that a worker registered now also includes its UUID. Any failure hashing the password will now also log the worker name + UUID. --- internal/manager/api_impl/workers.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/internal/manager/api_impl/workers.go b/internal/manager/api_impl/workers.go index 0f599824..99dbe7a4 100644 --- a/internal/manager/api_impl/workers.go +++ b/internal/manager/api_impl/workers.go @@ -33,8 +33,12 @@ func (f *Flamenco) RegisterWorker(e echo.Context) error { } // TODO: validate the request, should at least have non-empty name, secret, and platform. - - logger.Info().Str("name", req.Name).Msg("registering new worker") + workerUUID := uuid.New() + logger = logger.With(). + Str("name", req.Name). + Str("uuid", workerUUID). + Logger() + logger.Info().Msg("registering new worker") hashedPassword, err := passwordHasher.GenerateHashedPassword([]byte(req.Secret)) if err != nil { @@ -43,7 +47,7 @@ func (f *Flamenco) RegisterWorker(e echo.Context) error { } dbWorker := persistence.Worker{ - UUID: uuid.New(), + UUID: workerUUID, Name: req.Name, Secret: string(hashedPassword), Platform: req.Platform,