Worker: don't log error if may-i-keep-running is shut down
Don't log an error if a worker shutdown (indicated by the context closing) interrupts a may-i-keep-running call. Instead, log at debug level and just return "yes, keep running"; we want the Worker to stop the task because it is shutting down, and not because the Manager told us so.
This commit is contained in:
parent
03a021e14f
commit
2c79a10650
@ -4,6 +4,7 @@ package worker
|
||||
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
"net/http"
|
||||
|
||||
"github.com/rs/zerolog/log"
|
||||
@ -43,10 +44,16 @@ func (w *Worker) queryManagerForStateChange(ctx context.Context) *api.WorkerStat
|
||||
func (w *Worker) mayIKeepRunning(ctx context.Context, taskID string) api.MayKeepRunning {
|
||||
resp, err := w.client.MayWorkerRunWithResponse(ctx, taskID)
|
||||
if err != nil {
|
||||
log.Warn().
|
||||
Err(err).
|
||||
Str("task", taskID).
|
||||
Msg("error asking Manager may-I-keep-running task")
|
||||
if errors.Is(err, context.Canceled) {
|
||||
log.Debug().
|
||||
Str("task", taskID).
|
||||
Msg("may-I-keep-running query interrupted by shutdown")
|
||||
} else {
|
||||
log.Warn().
|
||||
Err(err).
|
||||
Str("task", taskID).
|
||||
Msg("error asking Manager may-I-keep-running task")
|
||||
}
|
||||
return api.MayKeepRunning{MayKeepRunning: true}
|
||||
}
|
||||
|
||||
|
Loading…
x
Reference in New Issue
Block a user