From 62ecd09f5ff9b788dafcb67d0385cdd3bd851869 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sybren=20A=2E=20St=C3=BCvel?= Date: Thu, 14 Jul 2022 18:50:34 +0200 Subject: [PATCH] Don't return 500 Error when Blender cannot be found on $PATH In the first-time wizard, if Blender cannot be found on $PATH but it can be found via .blend file association, that should just be reported as a normal sitation, and not as a `500 Internal Server Error`. --- internal/manager/api_impl/meta.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/internal/manager/api_impl/meta.go b/internal/manager/api_impl/meta.go index 42801040..9918e64c 100644 --- a/internal/manager/api_impl/meta.go +++ b/internal/manager/api_impl/meta.go @@ -184,8 +184,7 @@ func (f *Flamenco) FindBlenderExePath(e echo.Context) error { case errors.Is(err, fs.ErrNotExist): logger.Info().Msg("Blender could not be found as 'blender' on $PATH") case err != nil: - logger.Warn().Err(err).Msg("there was an error finding Blender as 'blender' on $PATH") - return sendAPIError(e, http.StatusInternalServerError, "there was an error finding Blender: %v", err) + logger.Info().Err(err).Msg("there was an error finding Blender as 'blender' on $PATH") default: response = append(response, api.BlenderPathCheckResult{ IsUsable: true,