blender/flamenco
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Cleanup: worker, remove debug timers

Browse Source 
Remove accidentally committed debug timing code.
This commit is contained in:
Sybren A. Stüvel 2022-04-21 19:14:09 +02:00
parent bcbacf6c42
commit 8937a6f06f
1 changed files with 1 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
internal/worker/upstream_buffer.go
View File

@ -258,7 +258,6 @@ func (ub *UpstreamBufferDB) Flush(ctx context.Context) error {
} }
func (ub *UpstreamBufferDB) flushFirstItem(ctx context.Context) (done bool, err error) { func (ub *UpstreamBufferDB) flushFirstItem(ctx context.Context) (done bool, err error) {
startTime := time.Now()
dbCtx, dbCtxCancel := context.WithTimeout(context.Background(), databaseContextTimeout) dbCtx, dbCtxCancel := context.WithTimeout(context.Background(), databaseContextTimeout)
defer dbCtxCancel() defer dbCtxCancel()
@ -275,8 +274,6 @@ func (ub *UpstreamBufferDB) flushFirstItem(ctx context.Context) (done bool, err
var taskID string var taskID string
var blob []byte var blob []byte
beforeQuery := time.Now()
err = tx.QueryRowContext(dbCtx, stmt).Scan(&rowID, &taskID, &blob) err = tx.QueryRowContext(dbCtx, stmt).Scan(&rowID, &taskID, &blob)
switch { switch {
case err == sql.ErrNoRows: case err == sql.ErrNoRows:
@ -288,7 +285,6 @@ func (ub *UpstreamBufferDB) flushFirstItem(ctx context.Context) (done bool, err
} }
logger := log.With().Str("task", taskID).Logger() logger := log.With().Str("task", taskID).Logger()
beforeUnmarshal := time.Now()
var update api.TaskUpdateJSONRequestBody var update api.TaskUpdateJSONRequestBody
if err := json.Unmarshal(blob, &update); err != nil { if err := json.Unmarshal(blob, &update); err != nil {
@ -301,7 +297,6 @@ func (ub *UpstreamBufferDB) flushFirstItem(ctx context.Context) (done bool, err
} }
return false, tx.Commit() return false, tx.Commit()
} }
beforeAPICall := time.Now()
// actually attempt delivery. // actually attempt delivery.
resp, err := ub.client.TaskUpdateWithResponse(ctx, taskID, update) resp, err := ub.client.TaskUpdateWithResponse(ctx, taskID, update)
@ -310,8 +305,6 @@ func (ub *UpstreamBufferDB) flushFirstItem(ctx context.Context) (done bool, err
return true, err return true, err
} }
afterAPICall := time.Now()
// Regardless of the response, there is little else to do but to discard the // Regardless of the response, there is little else to do but to discard the
// update from the queue. // update from the queue.
switch resp.StatusCode() { switch resp.StatusCode() {
@ -326,28 +319,10 @@ func (ub *UpstreamBufferDB) flushFirstItem(ctx context.Context) (done bool, err
Msg("queued task update discarded by Manager, unknown reason") Msg("queued task update discarded by Manager, unknown reason")
} }
beforeDiscard := time.Now()
if err := ub.discardRow(tx, rowID); err != nil { if err := ub.discardRow(tx, rowID); err != nil {
return false, err return false, err
} }
return false, tx.Commit()
beforeCommit := time.Now()
err = tx.Commit()
finalTime := time.Now()
log.Debug().
Stringer("prepare", beforeQuery.Sub(startTime)).
Stringer("query", beforeUnmarshal.Sub(beforeQuery)).
Stringer("unmarshal", beforeAPICall.Sub(beforeUnmarshal)).
Stringer("api", afterAPICall.Sub(beforeAPICall)).
Stringer("discard", beforeCommit.Sub(beforeDiscard)).
Stringer("commit", finalTime.Sub(beforeCommit)).
Stringer("total", finalTime.Sub(startTime)).
Msg("single flush")
return false, err
} }
func (ub *UpstreamBufferDB) discardRow(tx *sql.Tx, rowID int64) error { func (ub *UpstreamBufferDB) discardRow(tx *sql.Tx, rowID int64) error {