blender/flamenco
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Worker: fix issue running FFmpeg

Browse Source 
The `exeArg` command parameter was incorrectly always expected. It's now
optional, as it should be.
This commit is contained in:
Sybren A. Stüvel 2022-08-31 15:00:46 +02:00
parent a70bfb87d0
commit 9da75eef04
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
internal/worker/command_ffmpeg.go
View File

@ -120,10 +120,10 @@ func cmdFramesToVideoParams(logger zerolog.Logger, cmd api.Command) (CreateVideo
logger.Warn().Interface("command", cmd).Msg("missing 'exe' parameter") logger.Warn().Interface("command", cmd).Msg("missing 'exe' parameter")
return parameters, NewParameterMissingError("exe", cmd) return parameters, NewParameterMissingError("exe", cmd)
} }
if parameters.exeArgs, ok = cmdParameter[string](cmd, "exeArgs"); !ok {
logger.Warn().Interface("command", cmd).Msg("invalid 'exeArgs' parameter") // Ignore the `ok` return value, as a missing exeArgs key is fine:
return parameters, NewParameterInvalidError("exeArgs", cmd, "parameter must be string") parameters.exeArgs, _ = cmdParameter[string](cmd, "exeArgs")
}
if parameters.fps, ok = cmdParameter[float64](cmd, "fps"); !ok || parameters.fps == 0.0 { if parameters.fps, ok = cmdParameter[float64](cmd, "fps"); !ok || parameters.fps == 0.0 {
logger.Warn().Interface("command", cmd).Msg("missing 'fps' parameter") logger.Warn().Interface("command", cmd).Msg("missing 'fps' parameter")
return parameters, NewParameterMissingError("fps", cmd) return parameters, NewParameterMissingError("fps", cmd)