Shaman GC: better logging for file deletion errors

When the Shaman GC process cannot remove files, log a message that explains
that this happens (and why).
This commit is contained in:
Sybren A. Stüvel 2023-05-31 13:55:04 +02:00
parent caa2f9ccf1
commit c1fe3fb740

View File

@ -248,7 +248,13 @@ func (s *Server) gcDeleteOldFiles(doDryRun bool, oldFiles mtimeMap, logger zerol
pathLogger.Info().Msg("would delete unused file") pathLogger.Info().Msg("would delete unused file")
} else { } else {
pathLogger.Info().Msg("deleting unused file") pathLogger.Info().Msg("deleting unused file")
if err := s.fileStore.RemoveStoredFile(path); err == nil { err := s.fileStore.RemoveStoredFile(path)
switch {
case errors.Is(err, fs.ErrNotExist):
pathLogger.Debug().Msg("shaman: unused file disappeared before we could remove it during GC run")
case err != nil:
pathLogger.Error().Err(err).Msg("shaman: unable to delete unused file during GC run")
default:
deletedFiles++ deletedFiles++
} }
} }