From cbafacdff6829340b13e6d9a1733198fc8abb90c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sybren=20A=2E=20St=C3=BCvel?= Date: Thu, 7 Mar 2024 15:22:44 +0100 Subject: [PATCH] Manager: don't forward task log updates to MQTT Task log updates are big and frequent, and should not be sent via MQTT. At least not until we have a practical reason to do so. --- internal/manager/eventbus/mqtt_client.go | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/internal/manager/eventbus/mqtt_client.go b/internal/manager/eventbus/mqtt_client.go index a2a6b51c..d361084a 100644 --- a/internal/manager/eventbus/mqtt_client.go +++ b/internal/manager/eventbus/mqtt_client.go @@ -13,6 +13,8 @@ import ( "github.com/eclipse/paho.golang/paho" "github.com/rs/zerolog" "github.com/rs/zerolog/log" + + "projects.blender.org/studio/flamenco/pkg/api" ) const ( @@ -150,6 +152,11 @@ func (m *MQTTForwarder) queueRunner(queueRunnerCtx context.Context) { } func (m *MQTTForwarder) Broadcast(topic EventTopic, payload interface{}) { + if _, ok := payload.(api.EventTaskLogUpdate); ok { + // Task log updates aren't sent through MQTT, as that can generate a lot of traffic. + return + } + fullTopic := m.topicPrefix + string(topic) asJSON, err := json.Marshal(payload)