blender/flamenco
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Manager: only log task status change if there is an actual change

Browse Source 
Don't log "changes" from, say, `active` -> `active`.
This commit is contained in:
Sybren A. Stüvel 2022-07-19 17:47:43 +02:00
parent ac3236786b
commit d929885b06
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/manager/task_state_machine/task_state_machine.go
View File

@ -80,10 +80,12 @@ func (sm *StateMachine) taskStatusChangeOnly(
return fmt.Errorf("saving task to database: %w", err) return fmt.Errorf("saving task to database: %w", err)
} }
if oldTaskStatus != newTaskStatus {
// logStorage already logs any error, and an error here shouldn't block the // logStorage already logs any error, and an error here shouldn't block the
// rest of the function. // rest of the function.
_ = sm.logStorage.WriteTimestamped(logger, job.UUID, task.UUID, _ = sm.logStorage.WriteTimestamped(logger, job.UUID, task.UUID,
fmt.Sprintf("task changed status %s -> %s", oldTaskStatus, newTaskStatus)) fmt.Sprintf("task changed status %s -> %s", oldTaskStatus, newTaskStatus))
}
// Broadcast this change to the SocketIO clients. // Broadcast this change to the SocketIO clients.
taskUpdate := webupdates.NewTaskUpdate(task) taskUpdate := webupdates.NewTaskUpdate(task)