988cdf61ff
Upgrade: - `gorm.io/gorm` v1.23.8 → 1.25.2 - `github.com/glebarez/go-sqlite` v1.17.3 → v1.8.0 - `github.com/glebarez/sqlite` v1.4.6 → v1.8.0 and also some indirect dependencies. This is in the hope that some weird cases at Blender Studio get resolved. It appears that sometimes, for some unknown reason, when deleting a job, its tasks get reassigned to another job (instead of also getting deleted). Since there is no code in Flamenco itself to do this task deletion (it's all depending on SQLite following the foreign keys and cascading to tasks), I hope it was a bug in either GORM or SQLite that got fixed at some point.
49 lines
1.4 KiB
Go
49 lines
1.4 KiB
Go
// SPDX-License-Identifier: GPL-3.0-or-later
|
|
package persistence
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"strings"
|
|
"time"
|
|
|
|
"gorm.io/gorm"
|
|
)
|
|
|
|
var (
|
|
// errDatabaseBusy is returned by this package when the operation could not be
|
|
// performed due to SQLite being busy.
|
|
errDatabaseBusy = errors.New("database busy")
|
|
)
|
|
|
|
// ErrIsDBBusy returns true when the error is a "database busy" error.
|
|
func ErrIsDBBusy(err error) bool {
|
|
return errors.Is(err, errDatabaseBusy) || isDatabaseBusyError(err)
|
|
}
|
|
|
|
// isDatabaseBusyError returns true when the error returned by GORM is a
|
|
// SQLITE_BUSY error.
|
|
func isDatabaseBusyError(err error) bool {
|
|
if err == nil {
|
|
return false
|
|
}
|
|
|
|
// The exact error type is dependent on deep dependencies of GORM. The code
|
|
// below used to work, until an upgrade of one of those dependencies. This is
|
|
// why I feel it's more future-proof to just check for SQLITE_BUSY in the
|
|
// error text.
|
|
//
|
|
// sqlErr, ok := err.(*sqlite.Error)
|
|
// return ok && sqlErr.Code() == sqlite_lib.SQLITE_BUSY
|
|
return strings.Contains(err.Error(), "SQLITE_BUSY")
|
|
}
|
|
|
|
// setBusyTimeout sets the SQLite busy_timeout busy handler.
|
|
// See https://sqlite.org/pragma.html#pragma_busy_timeout
|
|
func setBusyTimeout(gormDB *gorm.DB, busyTimeout time.Duration) error {
|
|
if tx := gormDB.Exec(fmt.Sprintf("PRAGMA busy_timeout = %d", busyTimeout.Milliseconds())); tx.Error != nil {
|
|
return fmt.Errorf("setting busy_timeout: %w", tx.Error)
|
|
}
|
|
return nil
|
|
}
|