Sybren A. Stüvel d260a308bd Worker: enable write-ahead logging on the database
Now the Worker and the Manager share the same database initialisation
code (enabling foreign key constraints + write-ahead logging).

The foreign key constraints were already enabled before, but now it's done
with (a copy of) the same code as the Manager.
2023-12-14 10:10:03 +01:00

190 lines
5.0 KiB
Go

// Package persistence provides the database interface for Flamenco Manager.
package persistence
// SPDX-License-Identifier: GPL-3.0-or-later
import (
"context"
"fmt"
"time"
"github.com/rs/zerolog/log"
"gorm.io/gorm"
"github.com/glebarez/sqlite"
)
// DB provides the database interface.
type DB struct {
gormDB *gorm.DB
}
// Model contains the common database fields for most model structs. It is a
// copy of the gorm.Model struct, but without the `DeletedAt` or `UpdatedAt`
// fields. Soft deletion is not used by Flamenco, and the upstream buffer will
// not be updated. If it ever becomes necessary to support soft-deletion, see
// https://gorm.io/docs/delete.html#Soft-Delete
type Model struct {
ID uint `gorm:"primarykey"`
CreatedAt time.Time
}
func OpenDB(ctx context.Context, dsn string) (*DB, error) {
log.Info().Str("dsn", dsn).Msg("opening database")
db, err := openDB(ctx, dsn)
if err != nil {
return nil, err
}
if err := setBusyTimeout(db.gormDB, 5*time.Second); err != nil {
return nil, err
}
// Perfom some maintenance at startup.
db.vacuum()
if err := db.migrate(); err != nil {
return nil, err
}
log.Debug().Msg("database automigration succesful")
return db, nil
}
func openDB(ctx context.Context, dsn string) (*DB, error) {
globalLogLevel := log.Logger.GetLevel()
dblogger := NewDBLogger(log.Level(globalLogLevel))
config := gorm.Config{
Logger: dblogger,
NowFunc: nowFunc,
}
return openDBWithConfig(dsn, &config)
}
func openDBWithConfig(dsn string, config *gorm.Config) (*DB, error) {
dialector := sqlite.Open(dsn)
gormDB, err := gorm.Open(dialector, config)
if err != nil {
return nil, err
}
db := &DB{
gormDB: gormDB,
}
// Close the database connection if there was some error. This prevents
// leaking database connections & should remove any write-ahead-log files.
closeConnOnReturn := true
defer func() {
if !closeConnOnReturn {
return
}
if err := db.Close(); err != nil {
log.Debug().AnErr("cause", err).Msg("cannot close database connection")
}
}()
// Use the generic sql.DB interface to set some connection pool options.
sqlDB, err := gormDB.DB()
if err != nil {
return nil, err
}
// Only allow a single database connection, to avoid SQLITE_BUSY errors.
// It's not certain that this'll improve the situation, but it's worth a try.
sqlDB.SetMaxIdleConns(1) // Max num of connections in the idle connection pool.
sqlDB.SetMaxOpenConns(1) // Max num of open connections to the database.
// Always enable foreign key checks, to make SQLite behave like a real database.
log.Trace().Msg("enabling SQLite foreign key checks")
if err := db.pragmaForeignKeys(true); err != nil {
return nil, err
}
// Write-ahead-log journal may improve writing speed.
log.Trace().Msg("enabling SQLite write-ahead-log journal mode")
if tx := gormDB.Exec("PRAGMA journal_mode = WAL"); tx.Error != nil {
return nil, fmt.Errorf("enabling SQLite write-ahead-log journal mode: %w", tx.Error)
}
// Switching from 'full' (default) to 'normal' sync may improve writing speed.
log.Trace().Msg("enabling SQLite 'normal' synchronisation")
if tx := gormDB.Exec("PRAGMA synchronous = normal"); tx.Error != nil {
return nil, fmt.Errorf("enabling SQLite 'normal' sync mode: %w", tx.Error)
}
closeConnOnReturn = false
return db, nil
}
// nowFunc returns 'now' in UTC, so that GORM-managed times (createdAt,
// deletedAt, updatedAt) are stored in UTC.
func nowFunc() time.Time {
return time.Now().UTC()
}
// vacuum executes the SQL "VACUUM" command, and logs any errors.
func (db *DB) vacuum() {
tx := db.gormDB.Exec("vacuum")
if tx.Error != nil {
log.Error().Err(tx.Error).Msg("error vacuuming database")
}
}
func (db *DB) Close() error {
sqlDB, err := db.gormDB.DB()
if err != nil {
return fmt.Errorf("getting generic database interface: %w", err)
}
if err := sqlDB.Close(); err != nil {
return fmt.Errorf("closing database: %w", err)
}
return nil
}
func (db *DB) pragmaForeignKeys(enabled bool) error {
var (
value int
noun string
)
switch enabled {
case false:
value = 0
noun = "disabl"
case true:
value = 1
noun = "enabl"
}
log.Trace().Msgf("%sing SQLite foreign key checks", noun)
// SQLite doesn't seem to like SQL parameters for `PRAGMA`, so `PRAGMA foreign_keys = ?` doesn't work.
sql := fmt.Sprintf("PRAGMA foreign_keys = %d", value)
if tx := db.gormDB.Exec(sql); tx.Error != nil {
return fmt.Errorf("%sing foreign keys: %w", noun, tx.Error)
}
fkEnabled, err := db.areForeignKeysEnabled()
if err != nil {
return err
}
if fkEnabled != enabled {
return fmt.Errorf("SQLite database does not want to %se foreign keys, this may cause data loss", noun)
}
return nil
}
func (db *DB) areForeignKeysEnabled() (bool, error) {
log.Trace().Msg("checking whether SQLite foreign key checks are enabled")
var fkEnabled int
if tx := db.gormDB.Raw("PRAGMA foreign_keys").Scan(&fkEnabled); tx.Error != nil {
return false, fmt.Errorf("checking whether the database has foreign key checks are enabled: %w", tx.Error)
}
return fkEnabled != 0, nil
}