Simplify collecting designators for a joined BOM entry

Assign input designators once to a temporary variable for easy reusage.
This commit is contained in:
KV 2020-11-14 21:37:31 +01:00
parent 6378b96541
commit d2f8034961

View File

@ -106,11 +106,8 @@ def generate_bom(harness):
group_entries = [v for v in bom_entries if bom_types_group(v) == group] group_entries = [v for v in bom_entries if bom_types_group(v) == group]
designators = [] designators = []
for group_entry in group_entries: for group_entry in group_entries:
if group_entry.get('designators'): d = group_entry.get('designators')
if isinstance(group_entry['designators'], List): designators.extend(d if isinstance(d, List) else [d] if d else [])
designators.extend(group_entry['designators'])
else:
designators.append(group_entry['designators'])
designators = list(dict.fromkeys(designators)) # remove duplicates designators = list(dict.fromkeys(designators)) # remove duplicates
designators.sort() designators.sort()
total_qty = sum(entry['qty'] for entry in group_entries) total_qty = sum(entry['qty'] for entry in group_entries)