warehack.ing/WireViz
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update comment in src/wireviz/wireviz.py (#392)

Browse Source 
Clarify all exceptions catched, including changes in #392

Co-authored-by: kvid <kvid@users.noreply.github.com>
This commit is contained in:
Martin Rieder 2024-07-01 20:48:21 +02:00 committed by Daniel Rojas
parent d4902ce87d
commit ff6afac510
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/wireviz/wireviz.py
View File

@ -420,10 +420,13 @@ def _get_yaml_data_and_path(inp: Union[str, Path, Dict]) -> Tuple[Dict, Path]:
# if no FileNotFoundError exception happens, get file contents # if no FileNotFoundError exception happens, get file contents
yaml_str = open_file_read(yaml_path).read() yaml_str = open_file_read(yaml_path).read()
except (FileNotFoundError, OSError, ValueError) as e: except (FileNotFoundError, OSError, ValueError) as e:
# if inp is a long YAML string, Pathlib will raise OSError: [errno.ENAMETOOLONG] # if inp is a long YAML string, Pathlib will normally raise
# (in Windows, it seems OSError [errno.EINVAL] might be raised in some cases) # FileNotFoundError or OSError(errno = ENAMETOOLONG) when
# when trying to expand and resolve it as a path. # trying to expand and resolve it as a path, but in Windows
# Catch this error, but raise any others # might ValueError or OSError(errno = EINVAL or None) be raised
# instead in some cases (depending on the Python version).
# Catch these specific errors, but raise any others.
if type(e) is OSError and e.errno not in (EINVAL, ENAMETOOLONG, None): if type(e) is OSError and e.errno not in (EINVAL, ENAMETOOLONG, None):
raise e raise e
# file does not exist; assume inp is a YAML string # file does not exist; assume inp is a YAML string