blender/flamenco
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove the need to get elements by their ID

Browse Source 
Referencing elements outside the current component by ID is not a good
approach; using `this.$el.parentElement` is a bit cleaner.
This commit is contained in:
Sybren A. Stüvel 2022-05-27 16:44:51 +02:00
parent 339aafc1e4
commit 09dbcfe512
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
web/app/src/components/TasksTable.vue
View File

@ -5,7 +5,7 @@
:activeStatuses="shownStatuses" :activeStatuses="shownStatuses"
@click="toggleStatusFilter" @click="toggleStatusFilter"
/> />
<div class="task-list-container" id="task-list-container"> <div class="tabulator-container">
<div class="task-list" id="flamenco_task_list"></div> <div class="task-list" id="flamenco_task_list"></div>
</div> </div>
</template> </template>
@ -181,8 +181,8 @@ export default {
else if (row.reinitialize) row.reinitialize(true); else if (row.reinitialize) row.reinitialize(true);
}, },
_setTableHeight() { _setTableHeight() {
let jobDetailsColumn = document.getElementById('col-job-details'); const jobDetailsColumn = this.$el.parentElement;
let taskListTable = document.getElementById('task-list-container'); const tableContainer = this.tabulator.element.parentElement;
if (!jobDetailsColumn || !taskListTable) { if (!jobDetailsColumn || !taskListTable) {
return; return;