blender/flamenco
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Web: no longer do filtering when clicking on the 'status' table cell

Browse Source 
Clicking on a job/task in their respective lists will now always activate
it, regardless of where on the row was clicked.

Managing the filters by clicking on the status was a nice idea, but was
confusing in practice.
This commit is contained in:
Sybren A. Stüvel 2022-05-20 16:54:30 +02:00
parent ae0f4a7ca4
commit 1ac72bd3fc
2 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
web/app/src/components/JobsTable.vue
View File

@ -144,13 +144,6 @@ export default {
// store. There were some issues where navigating to another job would // store. There were some issues where navigating to another job would
// overwrite the old job's ID, and this prevents that. // overwrite the old job's ID, and this prevents that.
const rowData = plain(row.getData()); const rowData = plain(row.getData());
// Depending on which cell was clicked, take a different action.
const columnName = event.target.getAttribute("tabulator-field");
if (columnName == "status") {
this.toggleStatusFilter(rowData.status);
return;
}
this.$emit("tableRowClicked", rowData); this.$emit("tableRowClicked", rowData);
}, },
toggleStatusFilter(status) { toggleStatusFilter(status) {

7
web/app/src/components/TasksTable.vue
View File

@ -140,13 +140,6 @@ export default {
// store. There were some issues where navigating to another job would // store. There were some issues where navigating to another job would
// overwrite the old job's ID, and this prevents that. // overwrite the old job's ID, and this prevents that.
const rowData = plain(row.getData()); const rowData = plain(row.getData());
// Depending on which cell was clicked, take a different action.
const columnName = event.target.getAttribute("tabulator-field");
if (columnName == "status") {
this.toggleStatusFilter(rowData.status);
return;
}
this.$emit("tableRowClicked", rowData); this.$emit("tableRowClicked", rowData);
}, },
toggleStatusFilter(status) { toggleStatusFilter(status) {